Skip to content

perf: Don't pre-allocate memory #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
epage wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

perf: Don't pre-allocate memory #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion nixnet/_session/signals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

import typing # NOQA: F401

import six

from nixnet import _funcs
from nixnet import _props

Expand Down Expand Up @@ -49,7 +51,7 @@ def read(self):
"""
num_signals = len(self)
timestamps, values = _funcs.nx_read_signal_single_point(self._handle, num_signals)
for timestamp, value in zip(timestamps, values):
for timestamp, value in six.moves.zip(timestamps, values):
yield timestamp.value, value.value


Expand Down
4 changes: 3 additions & 1 deletion nixnet/convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
import typing # NOQA: F401
import warnings

import six

from nixnet import _frames
from nixnet import _funcs
from nixnet import _props
Expand Down Expand Up @@ -176,7 +178,7 @@ def _convert_bytes_to_signals(self, bytes):
# type: (bytes) -> typing.Iterable[typing.Tuple[int, float]]
num_signals = len(self.signals)
timestamps, values = _funcs.nx_convert_frames_to_signals_single_point(self._handle, bytes, num_signals)
for timestamp, value in zip(timestamps, values):
for timestamp, value in six.moves.zip(timestamps, values):
yield timestamp.value, value.value

def convert_frames_to_signals(self, frames):
Expand Down