Skip to content

Conversation

@mshafer-NI
Copy link
Collaborator

@mshafer-NI mshafer-NI commented Sep 11, 2025

Justification

We are aligning on action templates in ni/python-actions

The publishing code was already moved over to unblock it, now, let's get the PR pipelines switched over as well.

Major changes

  • Drop support for Python 3.8
  • Start using poetry 2 for PR builds
  • Add 3.14 and 3.14-free-threaded (3.14t) to the test matrix

Testing

PR should execute the modified actions

@github-actions
Copy link
Contributor

Thank you for contributing! 👋

@mshafer-NI mshafer-NI force-pushed the dev/switch_pr_checks_to_modern_tooling branch from f30f9ad to be6197a Compare November 14, 2025 20:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the CI/CD pipeline to use standardized actions from ni/python-actions and modernizes Python version support by dropping Python 3.8 and adding Python 3.14 (including the free-threaded variant).

Key changes:

  • Updated minimum Python version from 3.8 to 3.9
  • Adopted ni/python-actions templates for setup-python, setup-poetry, and analyze-project steps
  • Added Python 3.14 and 3.14t (free-threaded) to the test matrix

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Updated minimum Python version to 3.9 and simplified flake8-tidy-imports dependency constraint
poetry.toml Added configuration to create virtualenvs in-project for better CI caching
poetry.lock Updated lock file to reflect Python 3.9 minimum and removed flake8-tidy-imports 4.10.0
.github/workflows/PR.yml Migrated to ni/python-actions, expanded checks to run on all platforms, and added Python 3.14/3.14t support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@irwand irwand merged commit 177441f into ni:main Nov 19, 2025
33 checks passed
@mshafer-NI mshafer-NI deleted the dev/switch_pr_checks_to_modern_tooling branch November 19, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants