Skip to content

Conversation

@bkeryan
Copy link
Contributor

@bkeryan bkeryan commented Sep 22, 2025

What does this Pull Request accomplish?

Upgrade GitHub Actions workflows from ubuntu-20.04 to ubuntu-latest.

Why should this Pull Request be merged?

ubuntu-20.04 is no longer supported and is causing workflows to hang, waiting for a runner.

What testing has been done?

None, I don't have write/admin access.

@github-actions
Copy link
Contributor

Thank you for contributing! 👋

@bkeryan
Copy link
Contributor Author

bkeryan commented Sep 22, 2025

Thank you for contributing! 👋

@mshafer-NI @irwand @neilvana That's interesting. Notify-Convention-Change.yml has two jobs, and the job that does the notification already runs on ubuntu-latest. The job that runs on ubuntu-20.04 seems to be intended to restrict the other job to repos in the ni org.

I wonder if this can be simplified with a job-level if:.

@mshafer-NI
Copy link
Collaborator

I wonder if this can be simplified with a job-level if:.

Probably This was a workaround to not have comments get posted if I did a draft PR in my fork

@mshafer-NI mshafer-NI merged commit 326e78f into ni:main Oct 24, 2025
1 check passed
@bkeryan bkeryan deleted the users/bkeryan/ubuntu-latest branch October 24, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants