Skip to content

fix: error on partial config #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nikhilsinhaparseable merged 1 commit into from
Jan 19, 2025
Merged

fix: error on partial config #6

nikhilsinhaparseable merged 1 commit into from
Jan 19, 2025

Conversation

@de-sh
Copy link

@de-sh de-sh commented Jan 18, 2025

Fixes #XXXX.

Description

The PR ensures we error out when config is partial:
Screenshot 2025-01-19 at 12 41 52 AM

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@de-sh de-sh mentioned this pull request Jan 18, 2025
Merged
@nikhilsinhaparseable nikhilsinhaparseable merged commit d684bf3 into nikhilsinhaparseable:oidc-fix Jan 19, 2025
6 of 9 checks passed
@de-sh de-sh deleted the oidc-fix branch February 16, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@de-sh @nikhilsinhaparseable