Move O(n) operations to the initializer in exact_geodesics#201
Open
yutanoma wants to merge 1 commit intonmwsharp:masterfrom
Open
Move O(n) operations to the initializer in exact_geodesics#201yutanoma wants to merge 1 commit intonmwsharp:masterfrom
yutanoma wants to merge 1 commit intonmwsharp:masterfrom
Conversation
Owner
|
Hey, looks like I forgot to merge this from ages ago -- my apologies! Looking at it now, I have a question, it's not clear to me what Is it that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
exact_geodesicsso that you do not need to run O(n) operations whenever you query the geodesic path.This is especially useful when you have a fixed mesh/geometry and want to query the geodesic path multiple times.
Summary of contribution
geom.requireCornerAngles()andgeom.requireVertexGaussianCurvatures()to the initializerclear_data()that clears the data except the ones associated with the mesh/geometryUsage