Compatibility with recent nanoflann versions.#207
Merged
nmwsharp merged 2 commits intonmwsharp:masterfrom Sep 15, 2025
Merged
Conversation
Contributor
|
This would be great; I had to add support for a really old version of nanoflann in order to check this library into the Bazel registry: |
Owner
|
thanks for this! I went ahead and updated the included nanoflann at the same time, since it was an ancient version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::pair<>tonanoflann::ResultItem<>naonflann::SearchParamsrenamed tonaonflann::SearchParameters(because the first arg in the constructor was also removed from the API).IndexType/AccessorTypewas changed fromsize_ttouint32_t:Several fixes for IndexType which are not of integral types jlblancoc/nanoflann#154
I haven't updated the nanoflann version bundled with geometry-central, but I've confirmed that it compiles locally with the latest version.