Fixing a bug in the starter until the workflow is correctly construct…#26
Open
Roustalski wants to merge 1 commit intonode-ts:masterfrom
Open
Fixing a bug in the starter until the workflow is correctly construct…#26Roustalski wants to merge 1 commit intonode-ts:masterfrom
Roustalski wants to merge 1 commit intonode-ts:masterfrom
Conversation
…ed with a bus instance
Contributor
|
Hey @Roustalski - thanks heaps for raising this! The choice to remove I've fixed the bus reference in #27 and added a much needed test in an effort to prevent this library forcing the use of Cheers |
Contributor
|
Hey @Roustalski I tried responding to your email but looks like there's a problem with the server
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were getting ready to write an enterprise bus messaging queue from scratch because we didn't think anything existed for TS already, but we were excited to find
node-ts/*!Anyway, we saw that you recently removed InversifyJS as a hard dependency. Sad, but I understand the reasoning (We just InversifyJS extensively). The removal caused an issue with the starter, so I temporarily setup the bus with a container using Inversify in main until you guys work out how to get a bus instance to the workflows internally.