feat: Add batch message sending and publishing#231
Open
adenhertog wants to merge 1 commit intomasterfrom
Open
Conversation
This commit introduces batch sending capabilities to the bus implementation and its transports. New methods `sendBatch` (for commands) and `publishBatch` (for events) have been added to the `Transport` interface and implemented in the `BusInstance`. - SqsTransport: Implements batching using SNS `PublishBatchCommand`. Messages are grouped by topic and sent in chunks of up to 10 to respect SNS limits. - RabbitMqTransport: Throws a "not supported" error for batch operations, as the underlying transport does not natively support them. - InMemoryQueue: Implements batching by iterating and calling the single send/publish methods, suitable for testing. Unit tests have been added for the new methods in `BusInstance`. Integration tests have been added to the `transportTests` suite to cover batch operations for all relevant transports, verifying both successful execution and correct error handling for unsupported transports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces batch sending capabilities to the bus implementation and its transports.
New methods
sendBatch(for commands) andpublishBatch(for events) have been added to theTransportinterface and implemented in theBusInstance.PublishBatchCommand. Messages are grouped by topic and sent in chunks of up to 10 to respect SNS limits.Unit tests have been added for the new methods in
BusInstance. Integration tests have been added to thetransportTestssuite to cover batch operations for all relevant transports, verifying both successful execution and correct error handling for unsupported transports.