workflow(pr): improve #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
PR Overview
This PR updates the CI workflow to utilize caching for npm dependencies and switches script commands from "npm run" to "node --run" for better stability on Node 22.
- Adds caching for npm via actions/setup-node.
- Replaces "npm run" commands with "node --run" for linting, formatting, and test coverage.
- Removes the standalone test step in favor of the coverage-enhanced test step.
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/pr.yml | Updated workflow to implement caching and replace npm run commands with node --run equivalents |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (3)
.github/workflows/pr.yml:27
- Ensure that caching using 'cache: "npm"' is supported by the pinned version of actions/setup-node and behaves as expected with Node 22.
cache: 'npm'
.github/workflows/pr.yml:36
- Verify that 'node --run format' correctly triggers the formatting script, ensuring consistency with the previous command.
run: node --run format
.github/workflows/pr.yml:39
- Ensure that 'node --run test:coverage' covers the same test cases and behavior as the prior 'npm run test:coverage' command.
run: node --run test:coverage
bjohansebas
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
node --run(stable on node 22)Related Issues
No related issues
Check List