Skip to content

fix: linting #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flakey5 merged 1 commit into from
Mar 10, 2025
Merged

fix: linting #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions bin/cli.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ program
new Option(
'-o, --output <path>',
'Specify the relative or absolute output directory'
).makeOptionMandatory()
)
)
.addOption(
new Option(
Expand Down Expand Up @@ -112,18 +112,20 @@ const { getAllMajors } = createNodeReleases(changelog);

linter.lintAll(parsedApiDocs);

await runGenerators({
// A list of target modes for the API docs parser
generators: target,
// Resolved `input` to be used
input: input,
// Resolved `output` path to be used
output: resolve(output),
// Resolved SemVer of current Node.js version
version: coerce(version),
// A list of all Node.js major versions with LTS status
releases: await getAllMajors(),
});
if (target && output) {
await runGenerators({
// A list of target modes for the API docs parser
generators: target,
// Resolved `input` to be used
input: input,
// Resolved `output` path to be used
output: resolve(output),
// Resolved SemVer of current Node.js version
version: coerce(version),
// A list of all Node.js major versions with LTS status
releases: await getAllMajors(),
});
}

linter.report(reporter);

Expand Down
22 changes: 11 additions & 11 deletions src/linter/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,17 @@ import rules from './rules/index.mjs';
* @param {string[]} disabledRules List of disabled rules names
*/
const createLinter = (dryRun, disabledRules) => {
/**
* Retrieves all enabled rules
*
* @returns {import('./types').LintRule[]}
*/
const getEnabledRules = () => {
return Object.entries(rules)
.filter(([ruleName]) => !disabledRules.includes(ruleName))
.map(([, rule]) => rule);
};

const engine = createLinterEngine(getEnabledRules(disabledRules));

/**
Expand Down Expand Up @@ -56,17 +67,6 @@ const createLinter = (dryRun, disabledRules) => {
return issues.some(issue => issue.level === 'error');
};

/**
* Retrieves all enabled rules
*
* @returns {import('./types').LintRule[]}
*/
const getEnabledRules = () => {
return Object.entries(rules)
.filter(([ruleName]) => !disabledRules.includes(ruleName))
.map(([, rule]) => rule);
};

return {
lintAll,
report,
Expand Down
Loading