Skip to content

Conversation

@flakey5
Copy link
Member

@flakey5 flakey5 commented Mar 10, 2025

Allows for files to be ignored (aka removed) from the input so they won't be passed onto the generators. This is needed to support the skip_apidoc_files in Node's makefile (https://github.com/nodejs/node/blob/823c9b70c727e2efaa6dfd8e97551c31b45ff666/Makefile#L783)

@flakey5 flakey5 requested a review from a team as a code owner March 10, 2025 21:39
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just left one nitpick

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
@flakey5 flakey5 force-pushed the flakey5/20250310/ignore-files branch from 9f292d9 to 30a768b Compare March 10, 2025 21:57
@flakey5 flakey5 merged commit 3ad74f7 into main Mar 10, 2025
7 checks passed
@AugustinMauroy AugustinMauroy deleted the flakey5/20250310/ignore-files branch March 10, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants