Skip to content

refactor: split constants files #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AugustinMauroy merged 7 commits into from
Mar 24, 2025
Merged

refactor: split constants files #232

AugustinMauroy merged 7 commits into from
Mar 24, 2025

Conversation

@araujogui
Copy link
Member

@araujogui araujogui commented Mar 24, 2025

Description

Split constants.mjs in multiple smaller files

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I've covered new added functionality with unit tests if necessary.

@araujogui araujogui requested a review from a team as a code owner March 24, 2025 00:59
avivkeller
avivkeller approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

AugustinMauroy
AugustinMauroy approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@AugustinMauroy AugustinMauroy merged commit 7e52dc0 into nodejs:main Mar 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avivkeller avivkeller avivkeller approved these changes

@flakey5 flakey5 flakey5 approved these changes

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@araujogui @avivkeller @flakey5 @AugustinMauroy @bjohansebas