feat: display og images in social media #233
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flakey5
approved these changes
Mar 24, 2025
AugustinMauroy
requested changes
Mar 24, 2025
Member
AugustinMauroy
left a comment
AugustinMauroy
left a comment
There was a problem hiding this comment.
LGMT ! But we should have ability to op-out OG image. Because nodejs/nodejs.org can be output as static so OG will be 404
Member
Author
Any idea how to solve that? Also, if that starts returning 404, then the OG image wouldn't work on nodejs/nodejs.org either. |
ovflowd
requested changes
Apr 11, 2025
Member
ovflowd
left a comment
ovflowd
left a comment
There was a problem hiding this comment.
I don't think we should make any changes to the legacy generators.
Member
|
Given the comment above, I've closed this. However, you can always re open to continue discussion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, the images will be displayed on social media. It's not very important, but it's a small detail
https://nodejs.org/en/next-data/og/announcement/All%20%7C%20Node.js%20v22.14.0%20Documentation
output:
