-
Notifications
You must be signed in to change notification settings - Fork 24
feat(perf): offload generators to worker threads #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
313d287 to
1c16d08
Compare
AugustinMauroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ovflowd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM! But could you add benchmarks (simple time would suffice with different amount of threads) to check how much perf we gaining here.
|
For the following command: Where "Benchmark 1" ran with worker support, and "Benchmark 2" ran without: |
Description
This PR offloads generators to worker threads. I've done a check of each generator, and nothing crashes, however, please please do a run through to verify nothing changed.
Because some functions cannot be cloned,
toString()(on SemVer) has been replaced with.version, and similar for other SemVer related activities.Validation
The output should be identical to the current generation.
Related Issues
See https://openjs-foundation.slack.com/archives/CVAMEJ4UV/p1744161814523689
Check List