Skip to content

Conversation

@flakey5
Copy link
Member

@flakey5 flakey5 commented May 31, 2025

Re nodejs/node#57343 (comment)

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

@flakey5 flakey5 requested a review from a team as a code owner May 31, 2025 22:39
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.58%. Comparing base (97b3495) to head (49f6213).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #288   +/-   ##
=======================================
  Coverage   90.58%   90.58%           
=======================================
  Files          63       63           
  Lines        4767     4767           
  Branches      191      191           
=======================================
  Hits         4318     4318           
  Misses        446      446           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@flakey5 flakey5 force-pushed the flakey5/20250531/path branch from a0af5a7 to 77b967e Compare May 31, 2025 22:56
Re nodejs/node#57343 (comment)

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
@flakey5 flakey5 force-pushed the flakey5/20250531/path branch from 77b967e to 49f6213 Compare May 31, 2025 22:57
@avivkeller avivkeller merged commit 6e57af4 into main Jun 1, 2025
8 checks passed
@avivkeller avivkeller deleted the flakey5/20250531/path branch June 1, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants