fix(legacy-json): fix parameter ordering

[avivkeller]

This function was being called backwards, resulting in no parameters being marked optional.

[Copilot]

Pull Request Overview

This PR fixes the argument order of the updateDepth helper so that optional parameters are tracked correctly.

• Swaps the parameter order in updateDepth from (char, depth) to (depth, char)
• Adjusts the function definition to match its usage

Comments suppressed due to low confidence (1)

src/generators/legacy-json/utils/parseSignature.mjs:9

• The JSDoc @param annotations weren’t updated after swapping the parameters. Update the first tag to @param {Number} depth and the second to @param {String} char to match the new signature.

 * @param {String} char

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@580bc4d). Learn more about missing BASE report.
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #325   +/-   ##
=======================================
  Coverage        ?   71.51%           
=======================================
  Files           ?      117           
  Lines           ?     9721           
  Branches        ?      590           
=======================================
  Hits            ?     6952           
  Misses          ?     2766           
  Partials        ?        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[avivkeller]

It's being called like:

  optionalDepth = [...parameterName.slice(endingIdx + 1)].reduce(
    updateDepth,
    optionalDepth
  );

optionalDepth is being passed as "a", not "b".

[AugustinMauroy]

LGMT !

[avivkeller]

(Also, OPTIONAL_LEVEL_CHANGES[' '] || 0 is equal to 0 || 0, so that's been removed)

[ovflowd]

[ovflowd]

Fast-tracking :)