Skip to content

Conversation

@avivkeller
Copy link
Member

(CC @ovflowd)

Let's see if this speeds up the workflows significantly. If not, we can use a shared step, but this may be enough.

Copilot AI review requested due to automatic review settings July 16, 2025 12:41
@avivkeller avivkeller requested a review from a team as a code owner July 16, 2025 12:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables sparse checkout of the doc/api directory from the nodejs/node repository to potentially speed up CI workflows.

  • Adds a sparse-checkout specification under the actions/checkout step
  • Targets only doc/api to reduce the amount of checked-out files
Comments suppressed due to low confidence (1)

.github/workflows/generate.yml:57

  • Consider adding fetch-depth: 0 to ensure the sparse checkout retrieves the necessary commit history, as shallow clones (default depth: 1) may not support sparse-checkout correctly. For example:
- uses: actions/checkout@v3
  with:
    fetch-depth: 0
    sparse-checkout: |
      doc/api
          sparse-checkout: |

@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.14%. Comparing base (41ce248) to head (1a07f12).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #355   +/-   ##
=======================================
  Coverage   72.14%   72.14%           
=======================================
  Files         117      117           
  Lines        9992     9992           
  Branches      597      597           
=======================================
  Hits         7209     7209           
  Misses       2780     2780           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller avivkeller force-pushed the chore/ci/speedup-checkout branch from 1a07f12 to c5f4884 Compare July 16, 2025 13:06
@avivkeller avivkeller added the fast track This PR can land before the typical review time, with a :+1: from collaborators label Jul 16, 2025
@avivkeller
Copy link
Member Author

Requesting fast track.

@avivkeller avivkeller enabled auto-merge (squash) July 16, 2025 13:27
@avivkeller
Copy link
Member Author

@ovflowd You approved the fast-track, can you approve the PR, i need an infra approval

@avivkeller avivkeller merged commit cae76bf into main Jul 16, 2025
32 checks passed
@avivkeller avivkeller deleted the chore/ci/speedup-checkout branch July 16, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast track This PR can land before the typical review time, with a :+1: from collaborators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants