Skip to content

Conversation

@avivkeller
Copy link
Member

image_720

Improves the deprecation page by:

  1. Not slicing the DEPXXX: off the title
  2. Not bolding the code blocks, they should inherit their weight
  3. Putting the deprecation type inside an AlertBox

Copilot AI review requested due to automatic review settings July 20, 2025 21:16
@avivkeller avivkeller requested a review from a team as a code owner July 20, 2025 21:16
@vercel
Copy link

vercel bot commented Jul 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
api-docs-tooling ✅ Ready (Inspect) Visit Preview Jul 20, 2025 9:25pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the deprecation page by modifying how deprecation entries are displayed and formatted. The changes focus on enhancing the visual presentation and removing unnecessary text manipulation from deprecation titles.

  • Removes automatic slicing of "DEPXXX:" prefixes from deprecation titles
  • Updates CSS to ensure code blocks inherit font weight instead of being bolded
  • Wraps deprecation type information in AlertBox components for better visual hierarchy

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/generators/web/ui/index.css Adds font-weight: inherit to code elements to prevent unwanted bolding
src/generators/jsx-ast/utils/buildContent.mjs Removes colon-based title slicing logic and adds AlertBox rendering for deprecation types
src/generators/jsx-ast/constants.mjs Adds TYPE_PREFIX_LENGTH constant for consistent text processing

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@avivkeller avivkeller merged commit 0846862 into main Jul 24, 2025
17 checks passed
@avivkeller avivkeller deleted the feat/dep-improvements branch July 24, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants