-
Notifications
You must be signed in to change notification settings - Fork 24
fix(types,css): fix type parsing, and css headers #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves type parsing and CSS styling by updating regex patterns for better type matching and fixing header positioning styles.
- Improved type parsing with more flexible regex patterns and support for module-style types like
vm.Something - Added support for missing Node.js types and moved shared constants to a central location
- Minor CSS fix to include h5 and h6 elements in header positioning styles
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/queries/index.mjs | Updated regex patterns for more flexible type matching and stricter typed-list validation |
| src/utils/parser/slugger.mjs | New shared slugger utility moved from metadata generator |
| src/utils/parser/index.mjs | Added support for parsing module-style types like vm.Something |
| src/utils/parser/constants.mjs | Added new Node.js types and moved slug replacement constants from metadata |
| src/generators/web/ui/index.css | Extended CSS selector to include h5 and h6 elements |
| src/generators/metadata/utils/slugger.mjs | Removed file (moved to shared location) |
| src/generators/metadata/utils/parse.mjs | Updated import to use shared slugger utility |
| src/generators/metadata/constants.mjs | Removed file (constants moved to parser) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
==========================================
- Coverage 74.50% 74.28% -0.22%
==========================================
Files 120 118 -2
Lines 11067 11032 -35
Branches 694 693 -1
==========================================
- Hits 8245 8195 -50
- Misses 2819 2834 +15
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5e32efa to
2382133
Compare
ovflowd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might have noticed that with doc-kit PRs I tend to be more nitpicky, that's because differently from the Node.js website, where we don't generate things out of thin air, code-changes here can affect Node's documentation and how it structures and generates content. So here, I'll be a bit more extra demanding as we're reaching maturity and getting close to live on nodejs/node 🙇
Tests still failing? |
No. Not sure why Codecov didn't update that comment correctly 🤔 |
|
Have you updated the tests? 👀 |
|
This PR fixes the type parsing to:
[module].some.headersyntax (which accounts for several missing types)(In the process of making this, I noticed a slight CSS issue, so this PR also addresses that. I can make a new PR if needed, it's it's so minor I figured it was fine to include)