fix: add @actions/core as dependency
#450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@actions/core` is used in the GitHub logger transport despite not actually being installed directly, meaning it's only available when `@reporters/github` is downloaded w/ dev dependencies. In Node core we don't install dev dependencies causing this to throw. Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
=======================================
Coverage 74.56% 74.56%
=======================================
Files 107 107
Lines 10459 10459
Branches 681 681
=======================================
Hits 7799 7799
Misses 2658 2658
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
requesting fast track since blocks node core pr |
MattIPv4
approved these changes
Oct 1, 2025
Member
|
smth smth pnpm and this wouldnt be a problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@actions/coreis used in the GitHub logger transport despite not actually being installed directly, meaning it's only available when@reporters/githubis downloaded w/ dev dependencies. In Node core we don't install dev dependencies causing this to throw.