fix: add legacy-html-assets generator #479
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move asset folder copying to its own generator that we can call separately from the legacy-html generator Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #479 +/- ##
==========================================
- Coverage 74.01% 72.62% -1.39%
==========================================
Files 108 110 +2
Lines 10316 10553 +237
Branches 685 686 +1
==========================================
+ Hits 7635 7664 +29
- Misses 2678 2886 +208
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AugustinMauroy
approved these changes
Nov 3, 2025
Member
|
I don't love this approach, it feels like a waste of a generator. This should, IMO, be one generator, or no generators and handled by the Makefile (although I'd prefer the former) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move asset folder copying to its own generator that we can call separately from the legacy-html generator
Description
Validation
Related Issues
Check List
node --run testand all tests passed.node --run format&node --run lint.