-
Notifications
You must be signed in to change notification settings - Fork 24
infra: performance improvements #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
fe87384
feat: twoslash support
ovflowd 842a335
feat: just better compilation
ovflowd bd58920
chore: halve build time
ovflowd 47df004
chore: code cleanup
ovflowd 3f864e0
chore: add tests
ovflowd 478bb61
chore: server splitting (even more performance)
ovflowd 1b097af
chore: updated tests
ovflowd f7291e8
chore: doc update
ovflowd ff822db
chore: removed all unrelated changes
ovflowd 0c42c97
chore: removed unnecessary changes
ovflowd 34f0373
chore: get out of here
ovflowd c0ed071
chore: fix issue caused during applying old comments
ovflowd b4b4953
chore: code review changes
ovflowd 10e9e3e
chore: code review changes
ovflowd f539c8d
chore: speculation rules
ovflowd 8b1ada3
chore: improved the rules
ovflowd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /** | ||
| * Creates an enhanced require function that can resolve code-split chunks | ||
| * from a virtual file system before falling back to Node.js require. | ||
| * | ||
| * @param {Array<{fileName: string, code: string}>} chunks - Array of code-split chunks from bundler. | ||
| * @param {ReturnType<import('node:module').createRequire>} requireFn - Node.js require function for external packages. | ||
ovflowd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| */ | ||
| export function createChunkedRequire(chunks, requireFn) { | ||
| // Create a virtual file system from code-split chunks | ||
| const chunkModules = Object.fromEntries( | ||
| chunks.map(c => [`./${c.fileName}`, c.code]) | ||
| ); | ||
|
|
||
| /** | ||
| * Enhanced require function that resolves code-split chunks from virtual file system. | ||
| * | ||
| * @param {string} modulePath - Module path to require. | ||
| * @returns {*} Module exports. | ||
| */ | ||
| const chunkedRequire = modulePath => { | ||
| // Check virtual file system first for code-split chunks | ||
| if (chunkModules[modulePath]) { | ||
| const mod = { exports: {} }; | ||
|
|
||
| // Execute chunk code in isolated context with its own module.exports | ||
| const chunkFn = new Function( | ||
| 'module', | ||
| 'exports', | ||
| 'require', | ||
| chunkModules[modulePath] | ||
| ); | ||
|
|
||
| chunkFn(mod, mod.exports, chunkedRequire); | ||
|
|
||
| return mod.exports; | ||
| } | ||
|
|
||
| // Fall back to Node.js require for external packages | ||
| return requireFn(modulePath); | ||
| }; | ||
|
|
||
| return chunkedRequire; | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.