Skip to content

Conversation

@canerakdas
Copy link
Member

Description

Fixes the version information in the web generator title

Validation

Before;
image

After;
image

Copilot AI review requested due to automatic review settings November 11, 2025 16:34
@canerakdas canerakdas requested a review from a team as a code owner November 11, 2025 16:34
@vercel
Copy link

vercel bot commented Nov 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
api-docs-tooling Ready Ready Preview Nov 11, 2025 4:36pm

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.10%. Comparing base (cb4a520) to head (cead054).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/generators/web/utils/processing.mjs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #490   +/-   ##
=======================================
  Coverage   74.10%   74.10%           
=======================================
  Files         111      111           
  Lines       10562    10562           
  Branches      701      701           
=======================================
  Hits         7827     7827           
  Misses       2732     2732           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the version information displayed in the web generator's page title by correcting the property access on the version object.

  • Corrects the version property access from version to version.version to properly display the version string in the page title

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avivkeller avivkeller added the fast track This PR can land before the typical review time, with a :+1: from collaborators label Nov 11, 2025
@avivkeller
Copy link
Member

Fast tracking!

@avivkeller avivkeller merged commit d980054 into nodejs:main Nov 11, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast track This PR can land before the typical review time, with a :+1: from collaborators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants