-
Notifications
You must be signed in to change notification settings - Fork 24
chore: streamline with legacy #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
- Coverage 74.59% 74.35% -0.24%
==========================================
Files 112 112
Lines 10713 10747 +34
Branches 722 722
==========================================
Hits 7991 7991
- Misses 2719 2753 +34
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR streamlines the legacy-json and legacy-json-all generators to produce output more similar to the source format. The changes focus on conditionally including metadata fields and normalizing data types.
Key changes:
- Conditional metadata fields: meta object and its properties are now only included when non-empty
- Type normalization: stability index converted from string to number
- Enhanced source attribution: items are now tagged with their source module when aggregated
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/generators/legacy-json/utils/buildSection.mjs |
Refactored createMeta and createSection to conditionally include meta fields only when non-empty; converted stability index to number type |
src/generators/legacy-json-all/index.mjs |
Updated property copying logic to use explicit Array.isArray check and add source attribution to aggregated items |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@avivkeller can you please not block the PR with tiny stylistic nitpicks? 😅 |
My review is not a blocking one |
|
We can always iterate these stylistic things in follow-ups, I just want to unblock myself as there's another PR I want to get through. |
You didn't approve the PR ... |
|
Thank you! I’ve merged this to unblock any work |
This PR streamlines the legacy-json and legacy-json output to be more similar with the source. After this, checking the diff between both generators, the differences are minimal and differences in structure are 0.