Skip to content

Conversation

@ovflowd
Copy link
Member

@ovflowd ovflowd commented Dec 4, 2025

This PR streamlines the legacy-json and legacy-json output to be more similar with the source. After this, checking the diff between both generators, the differences are minimal and differences in structure are 0.

@ovflowd ovflowd requested a review from a team as a code owner December 4, 2025 02:59
Copilot AI review requested due to automatic review settings December 4, 2025 02:59
@vercel
Copy link

vercel bot commented Dec 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
api-docs-tooling Ready Ready Preview Dec 4, 2025 2:09pm

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 0% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.35%. Comparing base (1e96be7) to head (e0edcc0).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/generators/legacy-json/utils/buildSection.mjs 0.00% 44 Missing ⚠️
src/generators/legacy-json-all/index.mjs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
- Coverage   74.59%   74.35%   -0.24%     
==========================================
  Files         112      112              
  Lines       10713    10747      +34     
  Branches      722      722              
==========================================
  Hits         7991     7991              
- Misses       2719     2753      +34     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR streamlines the legacy-json and legacy-json-all generators to produce output more similar to the source format. The changes focus on conditionally including metadata fields and normalizing data types.

Key changes:

  • Conditional metadata fields: meta object and its properties are now only included when non-empty
  • Type normalization: stability index converted from string to number
  • Enhanced source attribution: items are now tagged with their source module when aggregated

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/generators/legacy-json/utils/buildSection.mjs Refactored createMeta and createSection to conditionally include meta fields only when non-empty; converted stability index to number type
src/generators/legacy-json-all/index.mjs Updated property copying logic to use explicit Array.isArray check and add source attribution to aggregated items

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ovflowd
Copy link
Member Author

ovflowd commented Dec 4, 2025

@avivkeller can you please not block the PR with tiny stylistic nitpicks? 😅

@avivkeller
Copy link
Member

@avivkeller can you please not block the PR with tiny stylistic nitpicks? 😅

My review is not a blocking one

@ovflowd
Copy link
Member Author

ovflowd commented Dec 4, 2025

We can always iterate these stylistic things in follow-ups, I just want to unblock myself as there's another PR I want to get through.

@ovflowd
Copy link
Member Author

ovflowd commented Dec 4, 2025

@avivkeller can you please not block the PR with tiny stylistic nitpicks? 😅

My review is not a blocking one

You didn't approve the PR ...

@avivkeller avivkeller merged commit 89bd624 into main Dec 4, 2025
19 checks passed
@avivkeller avivkeller deleted the chore/streamline-with-legacy branch December 4, 2025 14:15
@avivkeller
Copy link
Member

Thank you! I’ve merged this to unblock any work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants