Skip to content

Conversation

@avivkeller
Copy link
Member

This PR removes the to-vfile dependency, moves eslint-plugin-react-x to devDependencies, and replaces glob with the smaller and faster tinyglobby.

Copilot AI review requested due to automatic review settings December 19, 2025 15:10
@avivkeller avivkeller requested a review from a team as a code owner December 19, 2025 15:10
@vercel
Copy link

vercel bot commented Dec 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
api-docs-tooling Ready Ready Preview Dec 19, 2025 3:18pm

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 57.69231% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.86%. Comparing base (5a53779) to head (8292125).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/utils/highlighter.mjs 0.00% 8 Missing ⚠️
src/generators/jsx-ast/utils/transformer.mjs 0.00% 2 Missing ⚠️
src/generators/ast/index.mjs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #522      +/-   ##
==========================================
- Coverage   79.87%   79.86%   -0.01%     
==========================================
  Files         122      121       -1     
  Lines       12013    11995      -18     
  Branches      841      839       -2     
==========================================
- Hits         9595     9580      -15     
+ Misses       2415     2412       -3     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces the dependency count by removing to-vfile, moving eslint-plugin-react-x to devDependencies, and replacing glob with the smaller and faster tinyglobby library.

Key changes:

  • Replaced to-vfile's read() function with direct VFile constructor calls and Node.js fs.promises.readFile()
  • Replaced glob with tinyglobby for file globbing operations
  • Inlined the parseJsSource function into ast-js/index.mjs and removed the javascript.mjs parser file
  • Replaced hast-util-to-string usage in highlighter.mjs with direct property access

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/utils/highlighter.mjs Removed hast-util-to-string import and changed from toString(preElement) to direct preElement.children[0].value access
src/parsers/javascript.mjs Deleted entire file as the parseJsSource function is no longer needed
src/generators/jsx-ast/utils/transformer.mjs Added TODO comment acknowledging potential for removing toString dependency in the future
src/generators/ast/index.mjs Replaced to-vfile's read() with manual VFile creation and readFile(), replaced glob with tinyglobby
src/generators/ast-js/index.mjs Inlined the JavaScript parsing logic, replaced to-vfile usage, and switched from glob to tinyglobby
package.json Removed to-vfile and glob dependencies, added tinyglobby, moved eslint-plugin-react-x to devDependencies, updated several other dependencies to newer versions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avivkeller avivkeller marked this pull request as draft December 19, 2025 15:14
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM tho

@ovflowd ovflowd added the fast track This PR can land before the typical review time, with a :+1: from collaborators label Dec 19, 2025
@araujogui araujogui enabled auto-merge (squash) December 19, 2025 16:52
@araujogui araujogui merged commit e6e3f43 into main Dec 19, 2025
20 checks passed
@araujogui araujogui deleted the reduce-dep-count branch December 19, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast track This PR can land before the typical review time, with a :+1: from collaborators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants