Handle Int nodes.
#1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indutny
requested changes
Jan 6, 2020
Member
indutny
left a comment
indutny
left a comment
There was a problem hiding this comment.
I like the direction of this Pull Request and the idea in general! Let's make this happen 😁 Thank you for your effort!
src/frontend.ts
Outdated
|
|
||
| let result = [ | ||
| new this.implementation.node.Int( | ||
| new frontend.node.Int(this.id.id(name), field, bytes, signed, littleEndian, 0) |
Member
There was a problem hiding this comment.
Nitpick: Let's split it into multiple statements. Something like: const tmp = new frontend.node.Int(...).
src/frontend.ts
Outdated
| let next = result[0]; | ||
| for (let offset = 1; offset < node.bytes; offset++) { | ||
| result[offset] = new this.implementation.node.Int( | ||
| new frontend.node.Int(this.id.id(name + '_byte' + (offset + 1)), field, bytes, signed, littleEndian, offset) |
Member
There was a problem hiding this comment.
Nitpick: similar recommendation here. Perhaps even move this.id.id() to a separate statement too. Also, would be great opportunity to use template syntax here: ${name}_byte${offset + 1}.
Member
|
Oh and of course it needs a test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.