Skip to content

Conversation

@araujogui
Copy link
Member

@araujogui araujogui commented Jan 9, 2026

Related to nodejs/nodejs.org#8101, nodejs/Release#1119 (comment) and nodejs/nodejs.org#8529

  • Move filesystem calls out of the library code and into the bin script
  • Add TypeScript definitions to align with the website’s typed codebase
  • Create a responsive SVG

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

cc @aduh95 / @nodejs/releasers / @nodejs/lts to approve the PR :)

const d3n = Lib.create(options);

if (args.html) {
const Fs = require('fs');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const Fs = require('fs');
const Fs = require('node:fs');

would you mind using namespaced imports?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And maybe just importing what you need?

Suggested change
const Fs = require('fs');
const { writeFileSync } = require('fs');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants