Skip to content

fix: use BN_GENCB_get_arg accessor for OpenSSL 3.x compatibility #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boorad wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −11
Open

fix: use BN_GENCB_get_arg accessor for OpenSSL 3.x compatibility #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8866868
fix: use BN_GENCB_get_arg accessor
boorad Dec 4, 2025
a68a419
fix: remove cipher.h include as it's not in 3.x
boorad Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions src/ncrypto.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <openssl/pkcs12.h>
#include <openssl/rand.h>
#include <openssl/x509v3.h>
#include "openssl/cipher.h"

#ifndef NCRYPTO_NO_KDF_H
#include <openssl/kdf.h>
Expand Down Expand Up @@ -473,11 +472,9 @@ int BignumPointer::isPrime(int nchecks,
// TODO(@jasnell): This could be refactored to allow inlining.
// Not too important right now tho.
[](int a, int b, BN_GENCB* ctx) mutable -> int {
PrimeCheckCallback& ptr = *static_cast<PrimeCheckCallback*>(ctx->arg);
// Newer versions of openssl and boringssl define the BN_GENCB_get_arg
// API which is what is supposed to be used here. Older versions,
// however, omit that API.
// *static_cast<PrimeCheckCallback*>(BN_GENCB_get_arg(ctx));
// BN_GENCB is opaque in OpenSSL 3.x, must use accessor
PrimeCheckCallback& ptr =
*static_cast<PrimeCheckCallback*>(BN_GENCB_get_arg(ctx));
return ptr(a, b) ? 1 : 0;
},
&innerCb);
Expand Down Expand Up @@ -507,11 +504,9 @@ bool BignumPointer::generate(const PrimeConfig& params,
BN_GENCB_set(
cb.get(),
[](int a, int b, BN_GENCB* ctx) mutable -> int {
PrimeCheckCallback& ptr = *static_cast<PrimeCheckCallback*>(ctx->arg);
// Newer versions of openssl and boringssl define the BN_GENCB_get_arg
// API which is what is supposed to be used here. Older versions,
// however, omit that API.
// *static_cast<PrimeCheckCallback*>(BN_GENCB_get_arg(ctx));
// BN_GENCB is opaque in OpenSSL 3.x, must use accessor
PrimeCheckCallback& ptr =
*static_cast<PrimeCheckCallback*>(BN_GENCB_get_arg(ctx));
return ptr(a, b) ? 1 : 0;
},
&innerCb);
Expand Down