Skip to content

tools: fix vcbuild test when path contain spaces #56481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Dec 9, 2025
Merged

tools: fix vcbuild test when path contain spaces #56481

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fb22e0
tools: fix `vcbuild test` when path contain spaces
stduhpf Jan 5, 2025
a251a12
tools: fix vcbuild test whith consistent syntax
stduhpf Jan 5, 2025
f1b58d2
Apply suggestions
stduhpf Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions vcbuild.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ if defined package set stage_package=1
:: assign path to node_exe
set "node_exe=%config%\node.exe"
set "node_gyp_exe="%node_exe%" deps\npm\node_modules\node-gyp\bin\node-gyp"
set "npm_exe="%~dp0%node_exe%" %~dp0deps\npm\bin\npm-cli.js"
set "npm_exe="%node_exe%" deps\npm\bin\npm-cli.js"
if "%target_env%"=="vs2022" set "node_gyp_exe=%node_gyp_exe% --msvs_version=2022"
if "%target_env%"=="vs2026" set "node_gyp_exe=%node_gyp_exe% --msvs_version=2026"

Expand Down Expand Up @@ -625,9 +625,7 @@ if not defined doc if not defined build_addons (
)
if exist "tools\doc\node_modules\unified\package.json" goto skip-install-doctools
SETLOCAL
cd tools\doc
%npm_exe% ci
cd ..\..
%npm_exe% --prefix tools\doc ci
if errorlevel 1 goto exit
ENDLOCAL
:skip-install-doctools
Expand Down Expand Up @@ -770,9 +768,7 @@ goto lint-js-build

:lint-js-build
if not defined lint_js_build if not defined lint_js if not defined lint_js_fix goto lint-md-build
cd tools\eslint
%npm_exe% ci
cd ..\..
%npm_exe% --prefix tools\eslint ci

:lint-js
if not defined lint_js goto lint-js-fix
Expand All @@ -790,9 +786,7 @@ goto lint-md-build

:lint-md-build
if not defined lint_md if not defined format_md goto lint-md
cd tools\lint-md
%npm_exe% ci
cd ..\..
%npm_exe% --prefix tools\lint-md ci

:lint-md
if not defined lint_md goto format-md
Expand Down
Loading