Skip to content

Conversation

@hotpineapple
Copy link
Contributor

@hotpineapple hotpineapple commented Sep 6, 2025

implement argv config for sea including snapshot

this resolves todo message:

// TODO(joyeecheung): make the arguments configurable through the JSON
// config or a programmatic API.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications labels Sep 6, 2025
@hotpineapple hotpineapple force-pushed the feature/add-option-to-sea branch 6 times, most recently from 5fdc5d6 to 605d991 Compare September 6, 2025 16:53
@codecov
Copy link

codecov bot commented Sep 6, 2025

Codecov Report

❌ Patch coverage is 81.15942% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.55%. Comparing base (f9fcc74) to head (8aa1533).
⚠️ Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sea.cc 81.15% 8 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59786      +/-   ##
==========================================
- Coverage   88.56%   88.55%   -0.02%     
==========================================
  Files         704      704              
  Lines      208125   208480     +355     
  Branches    40003    40065      +62     
==========================================
+ Hits       184332   184614     +282     
- Misses      15809    15875      +66     
- Partials     7984     7991       +7     
Files with missing lines Coverage Δ
src/node_sea.cc 84.39% <81.15%> (-0.68%) ⬇️

... and 64 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hotpineapple hotpineapple force-pushed the feature/add-option-to-sea branch 2 times, most recently from dad1c1d to 99ec9a4 Compare September 6, 2025 17:56
@hotpineapple hotpineapple force-pushed the feature/add-option-to-sea branch 4 times, most recently from 5d6c28c to 8aa1533 Compare October 18, 2025 05:31
implement argv config for sea including snapshot
@hotpineapple hotpineapple marked this pull request as draft November 9, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants