Skip to content

Conversation

@KimSH39
Copy link
Contributor

@KimSH39 KimSH39 commented Sep 13, 2025

Refactor code in node_util.cc and uv.cc to remove unnecessary
calls to Environment::GetCurrent(args), which reduces extra lookups
and makes the code clearer.

  • Use args.GetIsolate() instead of env->isolate()
  • Use isolate->GetCurrentContext() instead of env->context()
  • Verified by running the full test suite.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Sep 13, 2025
@codecov
Copy link

codecov bot commented Sep 13, 2025

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (e105e82) to head (bd240cb).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/node_util.cc 85.00% 1 Missing and 2 partials ⚠️
src/uv.cc 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #59876   +/-   ##
=======================================
  Coverage   88.53%   88.53%           
=======================================
  Files         704      704           
  Lines      208087   208078    -9     
  Branches    40006    40012    +6     
=======================================
+ Hits       184223   184230    +7     
+ Misses      15869    15863    -6     
+ Partials     7995     7985   -10     
Files with missing lines Coverage Δ
src/uv.cc 90.62% <85.71%> (ø)
src/node_util.cc 79.80% <85.00%> (-0.57%) ⬇️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@daeyeon daeyeon added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 14, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants