Skip to content

Conversation

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Sep 28, 2025

This is an automated update of zlib to 1.3.1-5aa6173.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. zlib Issues and PRs related to the zlib subsystem. labels Sep 28, 2025
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 28, 2025
@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (2271d2d) to head (b20aefb).
⚠️ Report is 49 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #60043   +/-   ##
=======================================
  Coverage   88.53%   88.54%           
=======================================
  Files         703      703           
  Lines      208226   208226           
  Branches    40145    40145           
=======================================
+ Hits       184352   184368   +16     
+ Misses      15884    15874   -10     
+ Partials     7990     7984    -6     

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +56 to +58
#if defined(__GNUC__)
__attribute__((__target__("ssse3")))
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only relevant change for us.

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025
@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-zlib branch 2 times, most recently from 6ec11ba to 2c84ea4 Compare October 12, 2025 00:35
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-zlib branch 2 times, most recently from bab93d2 to 0a6ed0c Compare October 26, 2025 00:37
@nodejs-github-bot nodejs-github-bot changed the title deps: update zlib to 1.3.1-85f05b0 deps: update zlib to 1.3.1-5aa6173 Nov 2, 2025
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-zlib branch from 0a6ed0c to eeab294 Compare November 2, 2025 00:38
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-zlib branch from eeab294 to f8f95f8 Compare November 9, 2025 00:38
@targos targos force-pushed the actions/tools-update-zlib branch from f8f95f8 to 1f6af49 Compare November 10, 2025 11:18
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2025
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 10, 2025
@github-actions
Copy link
Contributor

Failed to start CI
   ⚠  Commits were pushed since the last approving review:
   ⚠  - deps: update zlib to 1.3.1-5aa6173
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/19229834114

@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-zlib branch from 1f6af49 to b20aefb Compare November 16, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. zlib Issues and PRs related to the zlib subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants