Skip to content

buffer: remove unreachable overflow check in atob #60161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haramj wants to merge 5 commits into
base: main
Choose a base branch
from
Open

buffer: remove unreachable overflow check in atob #60161

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bca05f6
buffer: throw RangeError on atob overflow
haramj Oct 8, 2025
eb77eb7
buffer: fix lint-js
haramj Oct 8, 2025
cb09cba
buffer: remove unreachable overflow check in atob
haramj Oct 12, 2025
a54015a
buffer: add assert.fail()
haramj Oct 13, 2025
f5c78ba
buffer: fix lint error
haramj Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ const {
inspect: utilInspect,
} = require('internal/util/inspect');

const assert = require('internal/assert');

const {
codes: {
ERR_BUFFER_OUT_OF_BOUNDS,
Expand Down Expand Up @@ -1302,9 +1304,9 @@ function atob(input) {
throw lazyDOMException(
'The string to be decoded is not correctly encoded.',
'InvalidCharacterError');
case -3: // Possible overflow
// TODO(@anonrig): Throw correct error in here.
throw lazyDOMException('The input causes overflow.', 'InvalidCharacterError');
Comment on lines -1305 to -1307
Copy link
Member

@Renegade334 Renegade334 Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An unrecognised error state shouldn't be ignored.

I was thinking something like

    case -3:
      assert.fail('Unrecognized simdutf error');

with internal assert added to the imports in the script header:

@@ -97,10 +97,11 @@ const {
 } = require('internal/util/types');
 const {
   inspect: utilInspect,
 } = require('internal/util/inspect');

+const assert = require('internal/assert');
 const {
   codes: {
     ERR_BUFFER_OUT_OF_BOUNDS,
     ERR_INVALID_ARG_TYPE,
     ERR_INVALID_ARG_VALUE,

case -3:
assert.fail('Unrecognized simdutf error');
break;
default:
return result;
}
Expand Down
Loading