Skip to content

Conversation

@moluopro
Copy link

When compiling the Android static library, I found that the patch file trap-handler.h.patch was outdated:

ubuntu:~/work/node$ ./android-configure patch
Node.js android configure: Found Python 3.12.3...
- Patches List -
[1] [deps/v8/src/trap-handler/trap-handler.h] related to https://github.com/nodejs/node/issues/36287
patching file ./deps/v8/src/trap-handler/trap-handler.h
patch unexpectedly ends in middle of line
Hunk #1 FAILED at 17.
1 out of 1 hunk FAILED -- saving rejects to file ./deps/v8/src/trap-handler/trap-handler.h.rej
Info: Tried to patch.

To ensure that ./android-configure patch runs correctly, I updated this file.

@moluopro
Copy link
Author

moluopro commented Oct 22, 2025

I have successfully completed the build on both lower (API level 24) and higher (API level 33) versions of the Android SDK. If this small patch can be merged, I will submit a new PR afterward.

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM since Android is self serve.

@moluopro moluopro changed the title android-patch: update trap-handler.h.patch build: update android-patch/trap-handler.h.patch Oct 23, 2025
@moluopro moluopro changed the title build: update android-patch/trap-handler.h.patch build: update android-patches/trap-handler.h.patch Oct 23, 2025
@moluopro moluopro requested a review from cjihrig October 23, 2025 14:10
@aduh95 aduh95 added the needs-ci PRs that need a full CI run. label Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants