Skip to content

buffer: speed up concat via TypedArray#set #60399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 10 commits into from
Nov 1, 2025
+32 −3
Merged

buffer: speed up concat via TypedArray#set #60399

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e10034f
buffer: speed up concat via TypedArray#set
gurgunday Oct 25, 2025
a3ef7d2
complete coverage
gurgunday Oct 25, 2025
1502f5c
store bufLength in a variable
gurgunday Oct 26, 2025
a5b268e
fix compat issue
gurgunday Oct 26, 2025
3062e7c
lint
gurgunday Oct 26, 2025
34adb7c
simplify
gurgunday Oct 26, 2025
ffd22c1
Revert "simplify"
gurgunday Oct 26, 2025
0a50b68
alternative implementation
gurgunday Oct 26, 2025
7e75cf4
add type check to set
gurgunday Oct 26, 2025
a8a5e19
fix test
gurgunday Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,11 @@ function _copyActual(source, target, targetStart, sourceStart, sourceEnd) {
if (nb <= 0)
return 0;

_copy(source, target, targetStart, sourceStart, nb);
if (sourceStart === 0 && nb === sourceLen) {
TypedArrayPrototypeSet(target, source, targetStart);
} else {
_copy(source, target, targetStart, sourceStart, nb);
}

return nb;
}
Expand Down
8 changes: 8 additions & 0 deletions test/parallel/test-buffer-concat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,13 @@ assert.throws(() => {
const random10 = common.hasCrypto ?
require('crypto').randomBytes(10) :
Buffer.alloc(10, 1);
const derived18 = Buffer.alloc(18);
for (let i = 0, j = 0; i < 18; i++) {
if (i < 10)
derived18[i] = random10[i];
else
derived18[i] = random10[j++];
}
const empty = Buffer.alloc(0);

assert.notDeepStrictEqual(random10, empty);
Expand All @@ -85,6 +92,7 @@ assert.deepStrictEqual(Buffer.concat([], 100), empty);
assert.deepStrictEqual(Buffer.concat([random10], 0), empty);
assert.deepStrictEqual(Buffer.concat([random10], 10), random10);
assert.deepStrictEqual(Buffer.concat([random10, random10], 10), random10);
assert.deepStrictEqual(Buffer.concat([random10, random10], 18), derived18);
assert.deepStrictEqual(Buffer.concat([empty, random10]), random10);
assert.deepStrictEqual(Buffer.concat([random10, empty, empty]), random10);

Expand Down
Loading