Skip to content

tools: add workflow to add author ready #60554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aduh95 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

tools: add workflow to add author ready #60554

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19c9e77
tools: add workflow to add `author ready`
aduh95 Nov 2, 2025
d4f0c23
fixup! tools: add workflow to add `author ready`
aduh95 Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 53 additions & 2 deletions .github/workflows/label-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,67 @@ name: Label PRs
on:
pull_request_target:
types: [opened]
pull_request_review:
types: [submitted]

permissions:
contents: read
permissions: {}

jobs:
label:
runs-on: ubuntu-latest
if: github.event_name != 'pull_request_review'

steps:
- uses: nodejs/node-pr-labeler@d4cf1b8b9f23189c37917000e5e17e796c770a6b # v1
with:
repo-token: ${{ secrets.GH_USER_TOKEN }}
configuration-path: .github/label-pr-config.yml

author_ready:
runs-on: ubuntu-latest
if: github.event_name == 'pull_request_review'
permissions:
issues: write
Copy link
Member

@avivkeller avivkeller Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If my understanding of https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#workflows-in-forked-repositories-1 is correct, the pull_request_review event doesn’t have the needed permissions for this to work?

steps:
- name: Add 'Author ready' label
run: |
gh pr view "$PR_URL" --json review,statusCheckRollup,mergeable,labels --jq '
if .mergeable == "MERGEABLE" and
.reviewDecision == "APPROVED" and
(.statusCheckRollup | all(.conclusion != "FAILURE")) and
((.labels | all(.name != "needs-ci" and .name != "author ready")) or (.labels | any(.name == "request-ci")))
then
halt_error
end | {
labels: .labels | map(.name),
failedChecks: .statusCheckRollup | map(select(.conclusion == "FAILURE")),
mergeable,
reviewDecision,
}' \
|| gh api graphql -f query='
query($owner: String!, $repo: String!, $pr: Int!) {
repository(owner: $owner, name: $repo) {
pullRequest(number: $pr) {
reviewThreads(first: 100) {
nodes {
isResolved
comments(first: 1) {
nodes {
body
author { login }
}
}
}
}
}
}
}' -F "owner=$OWNER" -F "repo=$REPO" -F "pr=$PR_NUMBER" --jq '
.data.repository.pullRequest.reviewThreads.nodes | if all(.isResolved)
then
halt_error
end
' \
|| gh pr edit "$PR_URL" --add-label 'author ready'
env:
GH_TOKEN: ${{ github.token }}
PR_URL: ${{ github.event.pull_request.html_url }}
Loading