test: fix test-strace-openat-openssl for RISC-V #60588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
kxxt
force-pushed
the
test-strace-openat-openssl-riscv
branch
2 times, most recently
from
38002d1 to
dbc6fa4
Compare
Recent architectures like RISC-V does not support open syscall,
which will cause strace to fail and thus test failure.
AssertionError [ERR_ASSERTION]: strace: invalid system call 'open'
This patch disables tracing open syscall for RISC-V in the test to fix
the test failure.
kxxt
force-pushed
the
test-strace-openat-openssl-riscv
branch
from
dbc6fa4 to
35705b1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60588 +/- ##
=======================================
Coverage 88.55% 88.56%
=======================================
Files 704 704
Lines 208077 208077
Branches 40076 40083 +7
=======================================
+ Hits 184271 184277 +6
+ Misses 15839 15823 -16
- Partials 7967 7977 +10 🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Nov 5, 2025
lpinca
approved these changes
Nov 5, 2025
kxxt
added a commit
to kxxt/archriscv-packages
that referenced
this pull request
Nov 7, 2025
- Fix test-strace-openat-openssl for RISC-V, upstreamed: nodejs/node#60588 - Fix randomly failing WPT tests, upstreamed: nodejs/node#60591 - Drop upstreamed patches - Temporarily disable test-snapshot-reproducible.js, I am still investigating it. - Now `check()` is supposed to pass, but some tests could hit revyos/revyos#27 on SG2042 so we might still need nocheck.
kxxt
added a commit
to kxxt/archriscv-packages
that referenced
this pull request
Nov 7, 2025
- Fix test-strace-openat-openssl for RISC-V, upstreamed: nodejs/node#60588 - Fix randomly failing WPT tests, upstreamed: nodejs/node#60591 - Drop upstreamed patches - Temporarily disable test-snapshot-reproducible.js, I am still investigating it. - Now `check()` is supposed to pass, but some tests could hit revyos/revyos#27 on SG2042 so we might still need nocheck.
Contributor
Author
|
Hi, is there still anything I need to do to get this PR merged? Thanks. |
richardlau
approved these changes
Nov 10, 2025
github-actions
bot
removed
the
request-ci
Collaborator
Contributor
Author
|
Looks like all CI failures are unrelated. Should I rebase this PR? |
Collaborator
Member
No, let's try the CI again. |
Collaborator
Contributor
Author
Thanks! The CI is green now. |
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 22a3eb0 |
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Nov 12, 2025
- Fix test-strace-openat-openssl for RISC-V, upstreamed: nodejs/node#60588 - Fix randomly failing WPT tests, upstreamed: nodejs/node#60591 - Drop upstreamed patches - Temporarily disable test-snapshot-reproducible.js, I am still investigating it. - Now `check()` is supposed to pass, but some tests could hit revyos/revyos#27 on SG2042 so we might still need nocheck.
targos
pushed a commit
that referenced
this pull request
Nov 27, 2025
Recent architectures like RISC-V does not support open syscall,
which will cause strace to fail and thus test failure.
AssertionError [ERR_ASSERTION]: strace: invalid system call 'open'
This patch disables tracing open syscall for RISC-V in the test to fix
the test failure.
PR-URL: #60588
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent architectures like RISC-V does not support open syscall, which will cause strace to fail and thus test failure.
This patch disables tracing open syscall for RISC-V in the test to fix the failure.