-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
url: add fast path to getPathFromURL decoder #60749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60749 +/- ##
==========================================
+ Coverage 88.54% 88.55% +0.01%
==========================================
Files 703 703
Lines 208222 208256 +34
Branches 40140 40152 +12
==========================================
+ Hits 184360 184420 +60
+ Misses 15882 15836 -46
- Partials 7980 8000 +20
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/70615/ Results |
|
Landed in 6e7a501 |
branch:
main:
The majority of file paths won't need decoding, so this PR avoids calling
decodeURIComponentwhen the path is pure ASCII with no encodings