Skip to content

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 21, 2025

That way we don't need to maintain our own regex escaping

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Nov 21, 2025
@aduh95 aduh95 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.50%. Comparing base (d729bec) to head (bbf7688).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60804      +/-   ##
==========================================
- Coverage   88.55%   88.50%   -0.05%     
==========================================
  Files         703      703              
  Lines      208259   208260       +1     
  Branches    40162    40151      -11     
==========================================
- Hits       184415   184317      -98     
- Misses      15844    15955     +111     
+ Partials     8000     7988      -12     
Files with missing lines Coverage Δ
lib/internal/util/debuglog.js 89.51% <100.00%> (-5.80%) ⬇️

... and 50 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95
Copy link
Contributor Author

aduh95 commented Nov 21, 2025

For some reason I don't see the same error locally, anyway I guess it's still too soon for that. We'll need https://chromium-review.googlesource.com/c/v8/v8/+/7265453 to land first

@aduh95 aduh95 closed this Nov 21, 2025
@aduh95 aduh95 deleted the RegExp.escape-util branch November 21, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants