-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
doc,test: remove usage of util.inherits #60817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60817 +/- ##
==========================================
+ Coverage 88.43% 88.55% +0.11%
==========================================
Files 703 703
Lines 208235 208254 +19
Branches 40085 40159 +74
==========================================
+ Hits 184162 184424 +262
+ Misses 16069 15828 -241
+ Partials 8004 8002 -2 🚀 New features to boost your workflow:
|
|
The doc part LGTM, can you remove the test change? IMO we want to validate there are no regressions on legacy APIs |
|
There are a specific test for this api. I had checked that . (I am on mobile I can't give the name of the test file) EDIT: file is |
|
I would still prefer the test change gets to be discussed separately |
|
@AugustinMauroy can you please split the PR as requested? |
I'm going to do that. kind of busy |
Description