Skip to content

Conversation

@AugustinMauroy
Copy link
Member

Description

  • Removing legacy api mention in doc
  • Removing Legacy api usage in test I just found it by doing a search for mention of it

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 22, 2025
@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (93c2581) to head (100af7f).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60817      +/-   ##
==========================================
+ Coverage   88.43%   88.55%   +0.11%     
==========================================
  Files         703      703              
  Lines      208235   208254      +19     
  Branches    40085    40159      +74     
==========================================
+ Hits       184162   184424     +262     
+ Misses      16069    15828     -241     
+ Partials     8004     8002       -2     

see 53 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95
Copy link
Contributor

aduh95 commented Nov 23, 2025

The doc part LGTM, can you remove the test change? IMO we want to validate there are no regressions on legacy APIs

@AugustinMauroy
Copy link
Member Author

AugustinMauroy commented Nov 23, 2025

There are a specific test for this api. I had checked that . (I am on mobile I can't give the name of the test file)

EDIT: file is test-util-inherits.js

@aduh95
Copy link
Contributor

aduh95 commented Nov 23, 2025

I would still prefer the test change gets to be discussed separately

@aduh95
Copy link
Contributor

aduh95 commented Dec 1, 2025

@AugustinMauroy can you please split the PR as requested?

@AugustinMauroy
Copy link
Member Author

@AugustinMauroy can you please split the PR as requested?

I'm going to do that. kind of busy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants