test_runner: propagate V8 options to child process #60999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60999 +/- ##
==========================================
+ Coverage 88.51% 88.53% +0.01%
==========================================
Files 703 703
Lines 208496 208512 +16
Branches 40213 40215 +2
==========================================
+ Hits 184555 184609 +54
+ Misses 15955 15948 -7
+ Partials 7986 7955 -31
🚀 New features to boost your workflow:
|
atlowChemi
approved these changes
Dec 9, 2025
| const child = spawnSync( | ||
| process.execPath, | ||
| [ | ||
| '--allow-natives-syntax', |
Member
There was a problem hiding this comment.
We don't actually validate this flag made any change. Do we want to pass this?
Maybe instead of calling globalThis.gc() we could check the execArgv inside the test?
Member
Author
There was a problem hiding this comment.
You absolutely right! Thanks for the suggestion!
marco-ippolito
approved these changes
Dec 9, 2025
benjamingr
approved these changes
Dec 9, 2025
RafaelGSS
approved these changes
Dec 9, 2025
github-actions
bot
removed
the
request-ci
Collaborator
RafaelGSS
added
lts-watch-v22.x
JakobJingleheimer
approved these changes
Dec 9, 2025
pmarchini
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/60999 ✔ Done loading data for nodejs/node/pull/60999 ----------------------------------- PR info ------------------------------------ Title test_runner: propagate V8 options to child process (#60999) Author Pietro Marchini <pietro.marchini94@gmail.com> (@pmarchini) Branch pmarchini:issue-60986 -> nodejs:main Labels needs-ci, test_runner, lts-watch-v22.x, lts-watch-v24.x Commits 1 - test_runner: propagate V8 options to child process Committers 1 - Pietro Marchini <pietro.marchini94@gmail.com> PR-URL: https://github.com/nodejs/node/pull/60999 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60999 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 08 Dec 2025 23:35:59 GMT ✔ Approvals: 6 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/60999#pullrequestreview-3554808102 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/60999#pullrequestreview-3555539052 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/60999#pullrequestreview-3556065594 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/60999#pullrequestreview-3556879192 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/60999#pullrequestreview-3556965246 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/60999#pullrequestreview-3559851497 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-12-09T12:33:04Z: https://ci.nodejs.org/job/node-test-pull-request/70446/ - Querying data for job/node-test-pull-request/70446/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/20116762228 |
PR-URL: nodejs#60999 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Contributor
|
Landed in 410174c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should address #60986!
At the moment, this solution doesn't take into account
NODE_OPTIONSnor the config file.In order to support both of them, at least for V8 options defined as
kV8Option, changes toGetOptionsAsFlagsare required.They will follow in a follow-up PR.