-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
assert,util: improve comparison performance #61176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 4 commits into
nodejs:main
from
BridgeAR:BridgeAR/2025-12-26-faster-comparison
Dec 29, 2025
Merged
assert,util: improve comparison performance #61176
nodejs-github-bot
merged 4 commits into
nodejs:main
from
BridgeAR:BridgeAR/2025-12-26-faster-comparison
Dec 29, 2025
+60
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure that the toStringTag symbol is used, if available instead of calculating the toString() value each time, if not needed (the type checks make a brand check, so there is no need to check the toStringTag, if non is defined on the object).
Member
Author
|
Local benchmark |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61176 +/- ##
==========================================
- Coverage 88.52% 88.52% -0.01%
==========================================
Files 703 703
Lines 208585 208613 +28
Branches 40225 40238 +13
==========================================
+ Hits 184650 184669 +19
Misses 15953 15953
- Partials 7982 7991 +9
🚀 New features to boost your workflow:
|
This is a workaround for errors recreated by error serdes.
Contributor
|
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1776/ Results |
aduh95
reviewed
Dec 27, 2025
cjihrig
approved these changes
Dec 27, 2025
benjamingr
approved these changes
Dec 27, 2025
marco-ippolito
approved these changes
Dec 29, 2025
Collaborator
Collaborator
|
Landed in 5c8ce91 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
needs-benchmark-ci
PR that need a benchmark CI run.
needs-ci
PRs that need a full CI run.
util
Issues and PRs related to the built-in util module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that the toStringTag symbol is used, if available instead of calculating the toString() value each time, if not needed (the type checks make a brand check, so there is no need to check the toStringTag, if non is defined on the object).