Skip to content

Conversation

@Ayoub-Mabrouk
Copy link

Replace native methods with primordials for consistency and security. This improves protection against prototype pollution.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Dec 29, 2025
@BridgeAR
Copy link
Member

@Ayoub-Mabrouk while we have these inconsistencies, it is actually not planned to migrate all code to primordials. Each of these changes needs a benchmark CI and while I appreciate the effort into migrating these, I would like to ask to not open further primordial PRs for now.

@avivkeller avivkeller added the needs-benchmark-ci PR that need a benchmark CI run. label Dec 29, 2025
@avivkeller
Copy link
Member

Please amend your commit to abide by the guidelines

@Ayoub-Mabrouk Ayoub-Mabrouk force-pushed the util-use-primordials-util branch from 1bcf3ee to 30ba2fd Compare December 29, 2025 16:45
Replace native methods with primordials.
@Ayoub-Mabrouk Ayoub-Mabrouk force-pushed the util-use-primordials-util branch from 30ba2fd to 7a355a9 Compare December 29, 2025 17:47
@Ayoub-Mabrouk
Copy link
Author

Ayoub-Mabrouk commented Dec 29, 2025

@Ayoub-Mabrouk while we have these inconsistencies, it is actually not planned to migrate all code to primordials. Each of these changes needs a benchmark CI and while I appreciate the effort into migrating these, I would like to ask to not open further primordial PRs for now.

I really appreciate your guidance and understand the concerns about CI and review load. My goal is to improve the project’s reliability and safety using primordials where it makes sense, following the official Node.js guidance. I’ll make sure any changes I propose are safe and beneficial for the project, and I’m happy to coordinate with subsystem teams to avoid stepping on anything sensitive.

@Ayoub-Mabrouk
Copy link
Author

Please amend your commit to abide by the guidelines

thanks, i have done it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-benchmark-ci PR that need a benchmark CI run. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants