Skip to content

tools: move Quic dependencies behind ad-hoc flag #61446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aduh95 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tools: move Quic dependencies behind ad-hoc flag #61446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions shell.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,14 @@
# Build options
icu ? pkgs.icu,
withAmaro ? true,
withQuic ? false,
withSQLite ? true,
withSSL ? true,
withTemporal ? false,
sharedLibDeps ? import ./tools/nix/sharedLibDeps.nix {
inherit
pkgs
withQuic
withSQLite
withSSL
withTemporal
Expand Down Expand Up @@ -81,6 +83,7 @@ pkgs.mkShell {
]
++ extraConfigFlags
++ pkgs.lib.optional (!withAmaro) "--without-amaro"
++ pkgs.lib.optional withQuic "--experimental-quic"
++ pkgs.lib.optional (!withSQLite) "--without-sqlite"
++ pkgs.lib.optional (!withSSL) "--without-ssl"
++ pkgs.lib.optional withTemporal "--v8-enable-temporal-support"
Expand Down
9 changes: 7 additions & 2 deletions tools/nix/sharedLibDeps.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
pkgs ? import ./pkgs.nix { },
withQuic ? false,
withSQLite ? true,
withSSL ? true,
withTemporal ? false,
Expand All @@ -12,8 +13,6 @@
gtest
libuv
nbytes
nghttp3
ngtcp2
simdjson
simdutf
uvwasi
Expand All @@ -33,6 +32,12 @@
];
};
}
// (pkgs.lib.optionalAttrs withQuic {
inherit (pkgs)
nghttp3
ngtcp2
;
})
// (pkgs.lib.optionalAttrs withSQLite {
inherit (pkgs) sqlite;
})
Expand Down