-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
stream: export namespace object from internal end-of-stream module #61455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61455 +/- ##
==========================================
- Coverage 88.54% 88.53% -0.01%
==========================================
Files 704 704
Lines 208971 208973 +2
Branches 40341 40341
==========================================
- Hits 185026 185011 -15
- Misses 15919 15936 +17
Partials 8026 8026
🚀 New features to boost your workflow:
|
|
Is this technically a breaking change? Would there be someone out there that was using And even if they were, they really should be using |
GH code search shows no uses, I wouldn't say there's any great benefit to marking this as a major change, but happy to be overruled. |
The current structure of
internal/streams/end-of-streamsetsmodule.exportsto theeosfunction, and defines other exports as properties on this function.However,
eosis exported directly from the public stream API, which currently exposes the rest of the module along with it.Changed to a conventional module namespace.