-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
build,test: add tests for binary linked with shared libnode #61463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review requested:
|
| 'type': 'none', | ||
| }], | ||
| # Only test platforms known to work. | ||
| ['OS not in "mac win linux"', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested these platforms locally, in the CI this currently would only be exercised on Linux. For other platforms where people happen to build and use libnode, I guess there's no need to potentially break their test flow with this - if they care about this use case they can add the platform name into this mix to ensure it's tested in their workflow.
|
For reference this is needed to support embedding https://nodejs.org/api/embedding.html |
|
Yes, for testing the Node.js bits it will take more work. See the TODO I left in |
This adds tests to ensure the V8 parts (v8, libplatform, cppgc) in shared libnode works correctly.
d8e1cea to
9da3c37
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61463 +/- ##
==========================================
+ Coverage 88.51% 88.52% +0.01%
==========================================
Files 704 704
Lines 208884 208995 +111
Branches 40334 40344 +10
==========================================
+ Hits 184889 185017 +128
+ Misses 15966 15964 -2
+ Partials 8029 8014 -15 🚀 New features to boost your workflow:
|
This adds tests to ensure the V8 parts (v8, libplatform, cppgc) in shared libnode works correctly.
Refs: #61144