Skip to content

Conversation

@joyeecheung
Copy link
Member

This adds tests to ensure the V8 parts (v8, libplatform, cppgc) in shared libnode works correctly.

Refs: #61144

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jan 21, 2026
'type': 'none',
}],
# Only test platforms known to work.
['OS not in "mac win linux"', {
Copy link
Member Author

@joyeecheung joyeecheung Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested these platforms locally, in the CI this currently would only be exercised on Linux. For other platforms where people happen to build and use libnode, I guess there's no need to potentially break their test flow with this - if they care about this use case they can add the platform name into this mix to ensure it's tested in their workflow.

@jeroen
Copy link
Contributor

jeroen commented Jan 21, 2026

For reference this is needed to support embedding https://nodejs.org/api/embedding.html

@joyeecheung
Copy link
Member Author

joyeecheung commented Jan 21, 2026

Yes, for testing the Node.js bits it will take more work. See the TODO I left in test/embedding/test-shared-embedding-v8.js (that thing currently fails, at least on macOS). This PR only tests the V8 bits.

This adds tests to ensure the V8 parts (v8, libplatform, cppgc)
in shared libnode works correctly.
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (58f5da2) to head (9da3c37).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61463      +/-   ##
==========================================
+ Coverage   88.51%   88.52%   +0.01%     
==========================================
  Files         704      704              
  Lines      208884   208995     +111     
  Branches    40334    40344      +10     
==========================================
+ Hits       184889   185017     +128     
+ Misses      15966    15964       -2     
+ Partials     8029     8014      -15     

see 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants