Skip to content

Conversation

@StefanStojanovic
Copy link
Contributor

@StefanStojanovic StefanStojanovic commented Jan 26, 2026

When we added VS2026 support, by accident we broke VS2022 compilation if you have both VS2026 and VS2022 installed (eg, you had to provide the vs2022 parameter). This PR fixes that bug.

@StefanStojanovic StefanStojanovic added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Jan 26, 2026
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 26, 2026
@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Jan 26, 2026

I checked this out and confirm it was broken before and is now fixed. 👍🏻

I hadn't previously noticed because I hadn't used .\vcbuild with a vs* parameter, even though I had done quite a few related tests!

In a side-by-side installation:

VS Build Tools 2022
- "Desktop development with C++" workload
- MSBuild support for LLVM (clang-cl)
- C++ Clang Compiler for Windows (19.1.5)

VS Build Tools 2026
- "Desktop development with C++" workload
- MSBuild support for LLVM (clang-cl)
- C++ Clang Compiler for Windows (20.1.8)

Command Result before Result after
.\vcbuild starts using 2026 starts using 2026
.\vcbuild vs2022 fails to start starts using 2022
.\vcbuild vs2026 starts using 2026 starts using 2026

Edit: fixed
@StefanStojanovic There's a misplaced comma in your original post, as it sounds like VS2026 support was added by accident.

@StefanStojanovic
Copy link
Contributor Author

@StefanStojanovic There's a misplaced comma in your original post, as it sounds like VS2026 support was added by accident.

You are right, I haven't noticed that. It is changed now.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 27, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 27, 2026
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants