Skip to content

sqlite: reserve local vectors space #61540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
araujogui wants to merge 2 commits into
base: main
Choose a base branch
from
Open

sqlite: reserve local vectors space #61540

araujogui wants to merge 2 commits into from
+12 −11

Conversation

@araujogui
Copy link
Member

@araujogui araujogui commented Jan 27, 2026

Reserve local vectors to prevent reallocations

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 27, 2026

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Jan 27, 2026
@codecov
Copy link

codecov bot commented Jan 27, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.76%. Comparing base (83893bb) to head (af35d93).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61540      +/-   ##
==========================================
- Coverage   89.78%   89.76%   -0.02%     
==========================================
  Files         672      672              
  Lines      203809   203809              
  Branches    39183    39183              
==========================================
- Hits       182980   182956      -24     
- Misses      13166    13175       +9     
- Partials     7663     7678      +15
Files with missing lines Coverage Δ
src/node_sqlite.cc 80.66% <100.00%> (ø)

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334
Renegade334 approved these changes Jan 27, 2026
View reviewed changes
@geeksilva97 geeksilva97 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 27, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 27, 2026
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 27, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71072/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@Renegade334 Renegade334 Renegade334 approved these changes

@geeksilva97 geeksilva97 geeksilva97 approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@araujogui @nodejs-github-bot @cjihrig @Renegade334 @geeksilva97 @RafaelGSS