chore: upgrade to next 15 #7155

ovflowd · 2024-10-30T19:59:38Z

This PR attempts to upgrade to Next.js 15 with the following changes:

Updated also dependencies, such as next-intl to the latest version, which required refactoring on its usage for compliance
Updated all our dynamic segments and routes to be more performant (build only what is needed in a minimal build, actually make it compatible with static exports)
We avoid building OG on static exports as they are costly to compute. Static exports should not support OG images at the moment.
Updates usages of JSON imports to use with instead of assert
Updated all other dependencies and fixed issues as needed
Updated Storybook to use the plain React version of Storybook as we don't use any specific Next.js feature that should run on Storybook.

vercel · 2024-10-30T19:59:43Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Nov 16, 2024 0:40am

apps/site/util/downloadUtils.ts

apps/site/app/[locale]/next-data/og/route.tsx

Copilot

Copilot reviewed 49 out of 64 changed files in this pull request and generated 1 suggestion.

Files not reviewed (15)

.vscode/settings.json: Language not supported
apps/site/.storybook/preview-head.html: Language not supported
apps/site/components/Downloads/ChangelogModal/index.module.css: Language not supported
apps/site/app/[locale]/next-data/og/route.tsx: Evaluated as low risk
apps/site/app/[locale]/next-data/changelog-data/[version]/route.ts: Evaluated as low risk
apps/site/.storybook/preview.tsx: Evaluated as low risk
apps/site/app/[locale]/error.tsx: Evaluated as low risk
COLLABORATOR_GUIDE.md: Evaluated as low risk
apps/site/app/[locale]/layout.tsx: Evaluated as low risk
apps/site/components/Common/Tabs/tests/index.test.mjs: Evaluated as low risk
apps/site/app/global-error.tsx: Evaluated as low risk
apps/site/app/[locale]/next-data/api-data/route.ts: Evaluated as low risk
apps/site/.storybook/main.ts: Evaluated as low risk
apps/site/app/[locale]/feed/[feed]/route.ts: Evaluated as low risk
apps/site/app/[locale]/next-data/blog-data/[category]/[page]/route.ts: Evaluated as low risk

apps/site/app/[locale]/next-data/og/[category]/[title]/route.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>

avivkeller · 2024-11-15T21:03:57Z

Hey, I locally changed the instances of 300 to VERCEL_REVALIDATE, and I don't see any build failures? Is this a Vercel thing or a Next.js thing?

apps/site/package.json

avivkeller

After updating all dependencies to their latest versions, the new package count is 1591, previously 1632.

package.json

apps/site/package.json

avivkeller · 2024-11-15T22:00:06Z

That's a really strange requirement. Regardless, as you said, that can be a followup (if it's even fixable). IMO for now the main thing is: Next.js 15 is working. The little kinks can be worked out in follow-ups if need be.

ovflowd · 2024-11-15T22:30:02Z

That's a really strange requirement. Regardless, as you said, that can be a followup (if it's even fixable). IMO for now the main thing is: Next.js 15 is working. The little kinks can be worked out in follow-ups if need be.

Yeah, agreed! Also regarding dependency updates we can do in a follow-up PR; BTW, feel free to test the website on the preview branch.

cc @nodejs/nodejs-website can we get another round of reviews?

apps/site/eslint.config.js

apps/site/package.json

avivkeller

Aside from the ESLint rule—which can easily be adjusted in a follow-up—this PR looks good to me

Co-authored-by: RedYetiDev <38299977+RedYetiDev@users.noreply.github.com>

ovflowd · 2024-11-16T00:47:55Z

I am going to be the crazy person and hit the merge button.

ovflowd · 2024-11-16T00:52:23Z

Next.js 15 🎉 here we are. Here's the significant changes brought within this PR:

We are not evalin'g JavaScript anymore within MDX; we've switched to using a non-eval approach with sval
We removed Sentry for the time being as it was causing bundling and compiling performance issues (to be debated, but we will potentially add it back once we finish discussions and investigations)
We've moved to the base storybook React framework without Next.js-specific feature sets.
We've simplified and optimized our Next.js configuration and other minor pieces that were slowing down the build.
We've removed the ChangelogModal component, which is redirecting to the release page of a Node.js release (cc @wesleytodd)
We added Vercel's native OpenTelemtry instrumentation implementation
We've optimized our MDX compilation and transpilation
We've optimized OG routes for static builds
We've optimized what gets build on the initial non-static build, even more benefitting from ISG/ISR
We've fixed links and language change on 404 pages
Several minor bug fixes and linting fixes
Updated several packages
Upgraded to Next.js 15.0.3

Co-authored-by: Claudio Wunder <cwunder@hubspot.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: RedYetiDev <38299977+RedYetiDev@users.noreply.github.com> Co-authored-by: Jan Amann <jan@amann.work> Co-authored-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>

This comment was marked as resolved.

Sign in to view

vercel bot had a problem deploying to Preview October 30, 2024 20:00 Failure

This comment was marked as resolved.

Sign in to view

AugustinMauroy reviewed Oct 30, 2024

View reviewed changes

apps/site/util/downloadUtils.ts Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

vercel bot had a problem deploying to Preview October 31, 2024 18:15 Failure

This comment was marked as resolved.

Sign in to view

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 31, 2024

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 31, 2024

ovflowd had a problem deploying to Storybook October 31, 2024 18:43 — with GitHub Actions Failure

This comment was marked as resolved.

Sign in to view

vercel bot had a problem deploying to Preview October 31, 2024 18:43 Failure

This comment was marked as resolved.

Sign in to view

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 31, 2024

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 31, 2024

ovflowd had a problem deploying to Storybook October 31, 2024 20:44 — with GitHub Actions Failure

This comment was marked as resolved.

Sign in to view

vercel bot deployed to Preview October 31, 2024 20:44 View deployment

ovflowd marked this pull request as ready for review October 31, 2024 20:45

ovflowd requested review from a team as code owners October 31, 2024 20:45

This comment was marked as resolved.

Sign in to view

ovflowd commented Oct 31, 2024

View reviewed changes

apps/site/app/[locale]/next-data/og/route.tsx Outdated Show resolved Hide resolved

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 31, 2024

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 31, 2024

Copilot AI reviewed Nov 15, 2024

View reviewed changes

apps/site/app/[locale]/next-data/og/[category]/[title]/route.tsx Outdated Show resolved Hide resolved

Update apps/site/app/[locale]/next-data/og/[category]/[title]/route.tsx

53b0d0a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>

vercel bot deployed to Preview November 15, 2024 19:50 View deployment

avivkeller reviewed Nov 15, 2024

View reviewed changes

apps/site/package.json Show resolved Hide resolved

avivkeller reviewed Nov 15, 2024

View reviewed changes

package.json Show resolved Hide resolved

apps/site/package.json Show resolved Hide resolved

chore: remove existsSync

7aa6ea1

vercel bot deployed to Preview November 15, 2024 21:41 View deployment

chore: simplify fragments

58215c5

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Nov 15, 2024

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 15, 2024

ovflowd deployed to Storybook November 15, 2024 21:44 — with GitHub Actions View deployment

vercel bot deployed to Preview November 15, 2024 21:44 View deployment

This comment was marked as resolved.

Sign in to view

avivkeller reviewed Nov 15, 2024

View reviewed changes

apps/site/eslint.config.js Show resolved Hide resolved

apps/site/package.json Show resolved Hide resolved

avivkeller approved these changes Nov 15, 2024

View reviewed changes

infra: use sval to parse javascript instead of mdx's evaluate (#7233)

1135f0b

Co-authored-by: RedYetiDev <38299977+RedYetiDev@users.noreply.github.com>

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Nov 16, 2024

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 16, 2024

ovflowd deployed to Storybook November 16, 2024 00:40 — with GitHub Actions View deployment

vercel bot deployed to Preview November 16, 2024 00:40 View deployment

ovflowd merged commit 7f751fd into main Nov 16, 2024
11 checks passed

ovflowd deleted the chore/nextjs-15 branch November 16, 2024 00:48

Uh oh!

chore: upgrade to next 15 #7155

chore: upgrade to next 15 #7155

Uh oh!

Conversation

ovflowd commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

avivkeller commented Nov 15, 2024

Uh oh!

Uh oh!

avivkeller left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

avivkeller commented Nov 15, 2024

Uh oh!

ovflowd commented Nov 15, 2024

Uh oh!

Uh oh!

Uh oh!

avivkeller left a comment

Choose a reason for hiding this comment

Uh oh!

ovflowd commented Nov 16, 2024

Uh oh!

Uh oh!

ovflowd commented Nov 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ovflowd commented Oct 30, 2024 •

edited

Loading

vercel bot commented Oct 30, 2024 •

edited

Loading