Skip to content

Conversation

@KunalKumar-1
Copy link
Contributor

Description

fixes: nodejs/node#51871

Updated the explanation of process.nextTick() to accurately reflect its execution timing in relation to the event loop phases, emphasizing that it runs immediately after the current operation, before moving to the next phase, not after "close callbacks."

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • [] I've covered new added functionality with unit tests if necessary.

@KunalKumar-1 KunalKumar-1 requested a review from a team as a code owner November 9, 2024 06:50
@vercel
Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 14, 2024 9:04pm

@avivkeller avivkeller enabled auto-merge November 16, 2024 03:24
@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗

@github-actions
Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.5% (591/653) 76.06% (178/234) 94.35% (117/124)

Unit Test Report

Tests Skipped Failures Errors Time
132 0 💤 0 ❌ 0 🔥 5.083s ⏱️

@avivkeller avivkeller added this pull request to the merge queue Nov 16, 2024
Merged via the queue into nodejs:main with commit 83081ef Nov 16, 2024
11 checks passed
@KunalKumar-1 KunalKumar-1 deleted the update_nextTick_timing branch November 19, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inaccurate sentence about the event loop tick and the process.nextTick

3 participants